Skip to content

Fix renaming regression and minor typo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2018
Merged

Fix renaming regression and minor typo #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca4e35
Fix maven command
Jan 6, 2018
a27ef5c
Fix renaming
Jan 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@ An Eclipse plug-in for developing in the TypeScript language.
* Run `update_version.sh old_version new_version` This is to change all version ".qualifier"
* Run `npm install`
* Run `grunt`
* Run `maven package`
* Run `mvn package`
* Install zip in Eclipse following `Install New Software...` -> `Add...` -> `Archive...`
13 changes: 11 additions & 2 deletions com.palantir.typescript/src/com/palantir/typescript/services/language/RenameLocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,19 @@ public final class RenameLocation {

private final String fileName;
private final TextSpan textSpan;
private final Boolean isDefinition;

public RenameLocation(
@JsonProperty("fileName") String fileName,
@JsonProperty("textSpan") TextSpan textSpan) {
@JsonProperty("textSpan") TextSpan textSpan,
@JsonProperty("isDefinition") Boolean isDefinition) {
checkNotNull(fileName);
checkNotNull(textSpan);

checkNotNull(isDefinition);

this.fileName = fileName;
this.textSpan = textSpan;
this.isDefinition = isDefinition;
}

public String getFileName() {
Expand All @@ -50,12 +54,17 @@ public String getFileName() {
public TextSpan getTextSpan() {
return this.textSpan;
}

public Boolean isDefinition() {
return this.isDefinition;
}

@Override
public String toString() {
return Objects.toStringHelper(this)
.add("fileName", this.fileName)
.add("textSpan", this.textSpan)
.add("isDefinition", this.isDefinition)
.toString();
}
}