eigen: Don't require conformability on length-0 dimensions #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
EricCousineau-TRI
left a comment
EricCousineau-TRI
left a comment
There was a problem hiding this comment.
+@jamiesnape for review, please.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @jamiesnape)
1 task
EricCousineau-TRI
force-pushed
the
issue-2098-drake-issue12633
branch
from
549f4ae to
0810381
Compare
jamiesnape
approved these changes
Jan 28, 2020
jamiesnape
left a comment
jamiesnape
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This was referenced Jun 29, 2022
jwnimmer-tri
pushed a commit
that referenced
this pull request
Jun 29, 2022
When converting an array to an Eigen matrix, ignore the strides if any dimension size is 0. If the array is empty, the strides aren't relevant, and especially numpy ≥ 1.23 explicitly sets the strides to 0 in this case. (See numpy commit dd5ab7b11520.) Update tests to verify that this works, and continues to work. (This test likely would have caught the behavior change with numpy 1.23.) This expands on the tests added by #38, but also reverts the logic change from that PR, as it is no longer needed, and brings the code closer in line with upstream, since #38 was never pushed upstream.
rpoyner-tri
added a commit
to rpoyner-tri/pybind11
that referenced
this pull request
Feb 28, 2025
…tLocomotion#38) Not wrong, but apparently no effect on our tests: same 15 failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch that proactively incorporates the following upstream PR (not sure how long it will take to review):
pybind#2099
Towards RobotLocomotion/drake#12633
This change is