Skip to content

Conversation

@czipperz
Copy link
Contributor

@czipperz czipperz commented Jul 5, 2016

No description provided.

@czipperz
Copy link
Contributor Author

czipperz commented Jul 5, 2016

#38

@czipperz
Copy link
Contributor Author

czipperz commented Jul 5, 2016

Not sure what I should be doing with my copyright notice.

@czipperz
Copy link
Contributor Author

czipperz commented Jul 5, 2016

https://msdn.microsoft.com/en-us/library/windows/desktop/aa376389(v=vs.85).aspx

This requires Advapi32.lib to be linked with on Windows. I don't know how to do that.

@dkrutsko dkrutsko added the Request A cool feature request for the library label Nov 13, 2016
@dkrutsko dkrutsko added this to the Robot 2.1.0 milestone Nov 13, 2016
@dkrutsko dkrutsko changed the base branch from master to dev February 25, 2017 19:00
@dkrutsko dkrutsko changed the base branch from dev to issue-50 March 6, 2017 05:17
@dkrutsko dkrutsko merged commit 16ece49 into Robot:issue-50 Mar 6, 2017
@dkrutsko
Copy link
Member

dkrutsko commented Mar 6, 2017

Merged! My apologies once again for taking a year to get to this. Some notes: The code will be part of the new System class (see #50), along with other useful functionality (like #77). I'll take care of including the necessary dependencies.

For the copyright header, it's consistent across the entire project, I don't include names in the core modules (not even mine). I'm trying to figure out how to best acknowledge all the wonderful contributors. I know some projects just point to the GitHub Contributors page, others point to a special thank you file. But since Robot consists of multiple closely related projects I was thinking of creating a special page on the robot website with links to everyone who contributed to the project. Please let me know if you have any feedback! And thanks again :-D

@czipperz
Copy link
Contributor Author

czipperz commented Mar 6, 2017

Ok cool. Feel free to remove the copyright notice. FYI The copyright on that file is not correct. I'll comment on the commit

// -------------------------------------------------------------------------- //
// //
// (C) 2010-2016 Robot Developers //
// (C) 2016 Chris Gregory [email protected] //
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be deleted and the one above should be (C) 2016-2017.

@dkrutsko
Copy link
Member

dkrutsko commented Mar 6, 2017

No problem! I'll correct the file as part of the integration process. It'll be part of #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request A cool feature request for the library

Development

Successfully merging this pull request may close these issues.

Create a new System class Add the ability to check if app is running as admin

2 participants