fix: update patch for kilted

[wep21]

No description provided.

[wep21]

@traversaro I find out build of gz_ros2_control fails due to missing gz_sensors_vendor on osx and linux-64, but somehow it succeeds on linux-aarch64. Could you take a look at log? The dependency chain is gz_ros2_control -> gz_sim_vendor -> gz_sensors_vendor and package.xml of these package seem sane.

[traversaro]

@traversaro I find out build of gz_ros2_control fails due to missing gz_sensors_vendor on osx and linux-64, but somehow it succeeds on linux-aarch64. Could you take a look at log? The dependency chain is gz_ros2_control -> gz_sim_vendor -> gz_sensors_vendor and package.xml of these package seem sane.

Sorry, I reached this late. Is this solved or you still have this problem?

[wep21]

@traversaro

Sorry, I reached this late. Is this solved or you still have this problem?

The problem has been solved by add_host patch dependencies.

[wep21]

@traversaro @Tobias-Fischer PR is ready. I appreciate it if you could review this PR.

[wep21]

@traversaro @Tobias-Fischer Is it better to merge PRs which was recently merged in ros-jazzy?

[Tobias-Fischer]

At some point we should try and get the various repositories unified, but it doesn't need to be in this PR (see also RoboStack/robostack.github.io#22 which becomes more and more critical with the many distributions we now ship ..)

[traversaro]

At some point we should try and get the various repositories unified, but it doesn't need to be in this PR (see also RoboStack/robostack.github.io#22 which becomes more and more critical with the many distributions we now ship ..)

Yes, I was thinking the same as I was recently adding feature in vinca.

[traversaro]

@traversaro @Tobias-Fischer Is it better to merge PRs which was recently merged in ros-jazzy?

The only critical one for me are the image_view fix and the ros_gz fix.

[wep21]

@traversaro

The only critical one for me are the image_view fix and the ros_gz fix.

added two commit

[traversaro]

Ready for merge for me, but I would wait for a double check from @Tobias-Fischer . fyi @knmcguire that was interested in kilted support.

[traversaro]

Ah, we may probably also want to switch to windows-2022 as windows-2019 image is in brownout and conda-forge is migrating to vs2022 in the next days see RoboStack/ros-jazzy#63, conda-forge/conda-forge.github.io#2138 and conda-forge/conda-forge-pinning-feedstock#7473 .

[wep21]

Ah, we may probably also want to switch to windows-2022 as windows-2019 image is in brownout and conda-forge is migrating to vs2022 in the next days see RoboStack/ros-jazzy#63, conda-forge/conda-forge.github.io#2138 and conda-forge/conda-forge-pinning-feedstock#7473 .Ah, we may probably also want to switch to windows-2022 as windows-2019 image is in brownout and conda-forge is migrating to vs2022 in the next days see RoboStack/ros-jazzy#63, conda-forge/conda-forge.github.io#2138 and conda-forge/conda-forge-pinning-feedstock#7473 .

@traversaro I cherry-picked the changes. Let's check windows error after ci.

[traversaro]

Windows seems happy also with windows-2022

[Tobias-Fischer]

Very great work, thanks a lot @wep21 for all this work, and to @traversaro for hints+reviewing the PR :)!

@wep21: Do you want to open a PR against https://github.com/RoboStack/robostack.github.io/tree/master to add kilted to the list of distributions?