Skip to content

Conversation

@solsson
Copy link
Contributor

@solsson solsson commented May 13, 2017

Also fixes some response codes.

@solsson solsson changed the base branch from master to 1.6.x May 13, 2017 18:21
@solsson solsson merged commit 8f3f96f into 1.6.x May 13, 2017
@solsson
Copy link
Contributor Author

solsson commented May 14, 2017

@takesson If you test this without docker, rweb reads $_SERVER as has been done before with config so I think you can use SetEnv and RewriteRule's E but not SetEnvIf.

@takesson
Copy link
Collaborator

takesson commented May 15, 2017

Testing with PHP-FPM.

This works:
RewriteRule .* - [E=REPOS_DOWNLOAD_RULE:|^/svn/[^/]+/testdir/.+|]

This works:
SetEnv REPOS_DOWNLOAD_RULE |^/svn/[^/]+/testdir/.+|

@takesson
Copy link
Collaborator

What are the pipe characters for?

@solsson
Copy link
Contributor Author

solsson commented May 15, 2017

Great. Thanks for examples of both.

PHP deprecated the old regex form in favor of PCRE, which start and end with a delimiter. The typical delimiter is / but with that you have to escape every slash in the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants