Skip to content

1.7: Normalize file upload name using the intl extension, support PHP 7.1 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 22, 2017
Merged

1.7: Normalize file upload name using the intl extension, support PHP 7.1 #14

merged 15 commits into from
Apr 22, 2017

Conversation

@solsson
Copy link
Contributor

@solsson solsson commented Apr 18, 2017

Proposed solution for #13

solsson added a commit to Reposoft/docker-svn that referenced this pull request Apr 18, 2017
@solsson
Installs lib for http://php.net/manual/en/class.normalizer.php
82970f2 
required by Reposoft/rweb#14
solsson added a commit to Reposoft/docker-svn that referenced this pull request Apr 20, 2017
@solsson
Adds REPOS_TEMP for Reposoft/rweb#14
3575f1d 
and because there is no TMP or TEMP in the image so temp lookup was rather slow
@solsson
Copy link
Contributor Author

solsson commented Apr 21, 2017

TODO skip normalize if the extension isn't installed, to be backwards compatible wrt server

@solsson solsson changed the title Normalize utf-8 to avoid svn wc errors 1.7: Normalize file upload name using the intl extension, support PHP 7.1 Apr 22, 2017
@solsson solsson merged commit 961268d into master Apr 22, 2017
solsson added a commit to Reposoft/docker-svn that referenced this pull request May 14, 2017
@solsson
Installs lib for http://php.net/manual/en/class.normalizer.php
d81816d 
required by Reposoft/rweb#14
solsson added a commit to Reposoft/docker-svn that referenced this pull request May 14, 2017
@solsson
Adds REPOS_TEMP for Reposoft/rweb#14
81c3442 
and because there is no TMP or TEMP in the image so temp lookup was rather slow
@takesson
Copy link
Collaborator

takesson commented Jun 13, 2017

Looks good to me. The default form Normalizer::FORM_C equals NFC is what normal keyboards produce.

  • Apple HFS does decomposed.
  • Apple APFS does not normalize, similar to other filesystems. However, it is still a good idea to normalize on NFC. I think Subversion no longer allows "normalized duplicates" in the repo, not entirely sure if that got merged though (Branko worked on it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@solsson @takesson