Skip to content

Conversation

@d-netto
Copy link
Member

@d-netto d-netto commented Mar 14, 2025

PR Description

Fix a failure introduced in #179.

The function that checks whether an AST node represents a method was incorrect in that PR.

This PR passes the relevant show tests in JuliaLang CI.

julia-RAI % julia                                     
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.2+RAI (2025-03-14)
 _/ |\__'_|_|_|\__'_|  |  dcn-fix-name-canonicalization/614e7b85c2 (fork: 430 commits, 620 days)
|__/                   |

julia> Base.runtests(["show"])
Running parallel tests with:
  nworkers() = 1
  nthreads() = 1
  Sys.CPU_THREADS = 4
  Sys.total_memory() = 64.000 GiB
  Sys.free_memory() = 13.791 GiB

Test  (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
show       (1) |        started at 2025-03-14T11:23:34.328
show       (1) |    11.59 |   0.19 |  1.6 |    2351.93 |   539.17

Test Summary: |   Pass  Broken   Total   Time
  Overall     | 129009       8  129017  12.2s
    SUCCESS

Checklist

Requirements for merging:

@d-netto d-netto merged commit 0e7de74 into v1.10.2+RAI Mar 14, 2025
5 checks passed
@d-netto d-netto deleted the dcn-fix-name-canonicalization branch March 14, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants