Skip to content

Two small fixes #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2022
Merged

Two small fixes #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea86668
Fix leading dimension check of eigen-/Schur vectors in LAPACKE
angsch May 1, 2022
9523efe
Fix docs stprfb
angsch May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_cgeev_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ lapack_int LAPACKE_cgeev_work( int matrix_layout, char jobvl, char jobvr,
LAPACKE_xerbla( "LAPACKE_cgeev_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -9;
LAPACKE_xerbla( "LAPACKE_cgeev_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -11;
LAPACKE_xerbla( "LAPACKE_cgeev_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_cgeevx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ lapack_int LAPACKE_cgeevx_work( int matrix_layout, char balanc, char jobvl,
LAPACKE_xerbla( "LAPACKE_cgeevx_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -11;
LAPACKE_xerbla( "LAPACKE_cgeevx_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -13;
LAPACKE_xerbla( "LAPACKE_cgeevx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_cgges_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ lapack_int LAPACKE_cgges_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_cgges_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -15;
LAPACKE_xerbla( "LAPACKE_cgges_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -17;
LAPACKE_xerbla( "LAPACKE_cgges_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_cggesx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ lapack_int LAPACKE_cggesx_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_cggesx_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -16;
LAPACKE_xerbla( "LAPACKE_cggesx_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -18;
LAPACKE_xerbla( "LAPACKE_cggesx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_dgeev_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ lapack_int LAPACKE_dgeev_work( int matrix_layout, char jobvl, char jobvr,
LAPACKE_xerbla( "LAPACKE_dgeev_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_dgeev_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_dgeev_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_dgeevx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ lapack_int LAPACKE_dgeevx_work( int matrix_layout, char balanc, char jobvl,
LAPACKE_xerbla( "LAPACKE_dgeevx_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_dgeevx_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -14;
LAPACKE_xerbla( "LAPACKE_dgeevx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_dgges_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ lapack_int LAPACKE_dgges_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_dgges_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -16;
LAPACKE_xerbla( "LAPACKE_dgges_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -18;
LAPACKE_xerbla( "LAPACKE_dgges_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_dggesx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ lapack_int LAPACKE_dggesx_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_dggesx_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -17;
LAPACKE_xerbla( "LAPACKE_dggesx_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -19;
LAPACKE_xerbla( "LAPACKE_dggesx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_sgeev_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ lapack_int LAPACKE_sgeev_work( int matrix_layout, char jobvl, char jobvr,
LAPACKE_xerbla( "LAPACKE_sgeev_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -10;
LAPACKE_xerbla( "LAPACKE_sgeev_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_sgeev_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_sgeevx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ lapack_int LAPACKE_sgeevx_work( int matrix_layout, char balanc, char jobvl,
LAPACKE_xerbla( "LAPACKE_sgeevx_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -12;
LAPACKE_xerbla( "LAPACKE_sgeevx_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -14;
LAPACKE_xerbla( "LAPACKE_sgeevx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_sgges_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ lapack_int LAPACKE_sgges_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_sgges_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -16;
LAPACKE_xerbla( "LAPACKE_sgges_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -18;
LAPACKE_xerbla( "LAPACKE_sgges_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_sggesx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ lapack_int LAPACKE_sggesx_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_sggesx_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -17;
LAPACKE_xerbla( "LAPACKE_sggesx_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -19;
LAPACKE_xerbla( "LAPACKE_sggesx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_zgeev_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ lapack_int LAPACKE_zgeev_work( int matrix_layout, char jobvl, char jobvr,
LAPACKE_xerbla( "LAPACKE_zgeev_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -9;
LAPACKE_xerbla( "LAPACKE_zgeev_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -11;
LAPACKE_xerbla( "LAPACKE_zgeev_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_zgeevx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ lapack_int LAPACKE_zgeevx_work( int matrix_layout, char balanc, char jobvl,
LAPACKE_xerbla( "LAPACKE_zgeevx_work", info );
return info;
}
if( ldvl < n ) {
if( ldvl < 1 || ( LAPACKE_lsame( jobvl, 'v' ) && ldvl < n ) ) {
info = -11;
LAPACKE_xerbla( "LAPACKE_zgeevx_work", info );
return info;
}
if( ldvr < n ) {
if( ldvr < 1 || ( LAPACKE_lsame( jobvr, 'v' ) && ldvr < n ) ) {
info = -13;
LAPACKE_xerbla( "LAPACKE_zgeevx_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_zgges_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ lapack_int LAPACKE_zgges_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_zgges_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -15;
LAPACKE_xerbla( "LAPACKE_zgges_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -17;
LAPACKE_xerbla( "LAPACKE_zgges_work", info );
return info;
Expand Down
4 changes: 2 additions & 2 deletions LAPACKE/src/lapacke_zggesx_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ lapack_int LAPACKE_zggesx_work( int matrix_layout, char jobvsl, char jobvsr,
LAPACKE_xerbla( "LAPACKE_zggesx_work", info );
return info;
}
if( ldvsl < n ) {
if( ldvsl < 1 || ( LAPACKE_lsame( jobvsl, 'v' ) && ldvsl < n ) ) {
info = -16;
LAPACKE_xerbla( "LAPACKE_zggesx_work", info );
return info;
}
if( ldvsr < n ) {
if( ldvsr < 1 || ( LAPACKE_lsame( jobvsr, 'v' ) && ldvsr < n ) ) {
info = -18;
LAPACKE_xerbla( "LAPACKE_zggesx_work", info );
return info;
Expand Down
2 changes: 1 addition & 1 deletion SRC/ctprfb.f
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
*> \brief \b CTPRFB applies a real or complex "triangular-pentagonal" blocked reflector to a real or complex matrix, which is composed of two blocks.
*> \brief \b CTPRFB applies a complex "triangular-pentagonal" block reflector to a complex matrix, which is composed of two blocks.
*
* =========== DOCUMENTATION ===========
*
Expand Down
2 changes: 1 addition & 1 deletion SRC/dtprfb.f
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
*> \brief \b DTPRFB applies a real or complex "triangular-pentagonal" blocked reflector to a real or complex matrix, which is composed of two blocks.
*> \brief \b DTPRFB applies a real "triangular-pentagonal" block reflector to a real matrix, which is composed of two blocks.
*
* =========== DOCUMENTATION ===========
*
Expand Down
Loading