-
Notifications
You must be signed in to change notification settings - Fork 480
Fix some typos in comments #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
95b6abf
unify comments: homogenize notation for transpose (**T) and conjugate…
jip a0634a9
unify comments: TRANS parameter
jip f42f512
revert "comments fixed: expression for residual in xTBT02"
jip 8262b4a
fix comments: expression for residual
jip 2eeed4b
unify comments: expression for residual
jip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still incorrect. The expression
norm(op(A)*X - B) / ( norm(op(A)) * norm(X) * EPS )is a number, so it does not have right-hand sides. I suggest something like:What do you think?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks better. Two adjoining "where" sections (the first one - "for every column b of B" - is implicit, and the second one is explicit) could be merged:
but this is a matter of taste.
I believe this variant is incorrect, too. The original comment states "x and b are N by NRHS matrices". So will be the residual
R := b - op(A)*x. The code computes taxicab-based norm|| R(j) ||for each j-th column R(j) from R. Then it takes amax(j) || R(j) ||which means in toto a computing of kinda 1-norm, but based on taxicab-based norm|Re(z)| + |Im(z)|, not magnitude-based norm|z|. So, the phrase "the maximum over" is excessive.And this variant may be improved further:
norm(op(A)*X - B)notnorm(B - op(A)*X)since the first is the exact expression which is computed. I know they give identical results. I don't insist on this summands swapping here.So, the result may look like this:
When "kinda 1-norms" in both
norm(op(A)*X - B)andnorm(X)will be replaced by "true 1-norm", then the following statement could be added: "The norm used is the 1-norm.".I'm ready to update this PR with any of variants discussed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go with either this one or the version I proposed. Maybe you can modify it a bit:
As you pointed out, the
normoperator is that "kinda 1-norm" for vectors of size N, in which|Re(z)| + |Im(z)|replaces the magnitude|z|for all complex scalars z. This is what the subroutine computes if I understand the algorithm correctly.I don't agree with this proposal. The algorithm does not compute
norm(X), where "capital" X is the original input matrix. Maybe I am missing something, please correct me if I am wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry for delayed answer)
I think you are right. I'll use the last variant you've proposed:
I'll try either to update this PR or to create a new one.