Add LAPACK_FORTRAN_STRLEN_END info to function prototypes in LAPACKE/include/lapack.h #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weslleyspereira
previously approved these changes
May 20, 2021
Collaborator
|
Hi @eshpc. Thanks for the improvement! I identified 2 typos. Please, see the diff patch below: diff --git a/LAPACKE/include/lapack.h b/LAPACKE/include/lapack.h
index f10113e09..4ab0eb246 100644
--- a/LAPACKE/include/lapack.h
+++ b/LAPACKE/include/lapack.h
@@ -5973,7 +5973,7 @@ void LAPACK_sgtsvx_base(
#endif
#define LAPACK_zgtsvx_base LAPACK_GLOBAL(zgtsvx,ZGTSVX)
-void LAPACK_zgtsv_basex(
+void LAPACK_zgtsvx_base(
char const* fact, char const* trans,
lapack_int const* n, lapack_int const* nrhs,
lapack_complex_double const* DL,
@@ -6834,7 +6834,7 @@ void LAPACK_zheevd_base(
#endif
#define LAPACK_cheevd_2stage_base LAPACK_GLOBAL(cheevd_2stage,CHEEVD_2STAGE)
-void LAPACK_cheevd_2stag_basee(
+void LAPACK_cheevd_2stage_base(
char const* jobz, char const* uplo,
lapack_int const* n,
lapack_complex_float* A, lapack_int const* lda, |
Contributor
Author
|
Hi @weslleyspereira Thanks for spotting those typos. |
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 1894 1894
Lines 190677 190677
=======================================
Hits 157063 157063
Misses 33614 33614
Continue to review full report at Codecov.
|
weslleyspereira
approved these changes
May 25, 2021
mgates3
added a commit
to mgates3/blaspp
that referenced
this pull request
Oct 9, 2023
mgates3
added a commit
to mgates3/lapackpp
that referenced
this pull request
Oct 9, 2023
mgates3
added a commit
to mgates3/lapackpp
that referenced
this pull request
Oct 9, 2023
mgates3
added a commit
to mgates3/blaspp
that referenced
this pull request
Oct 9, 2023
mgates3
added a commit
to mgates3/blaspp
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the hidden arguments of type size_t to the function prototypes in LAPACKE/include/lapack.h, controlled by defining LAPACK_FORTRAN_STRLEN_END. This should hopefully solve #339 for almost all current systems, although note that Win32 + stdcall has a different calling convention that is not supported by these LAPACKE and CBLAS headers.