Fixed #182 for N < 1 #225
Closed
Fixed #182 for N < 1 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a possible call to laruv routines when N < 1. Signed-off-by: Nick Papior <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 82.67% 82.67% -0.01%
==========================================
Files 1841 1841
Lines 178570 178574 +4
==========================================
+ Hits 147627 147629 +2
- Misses 30943 30945 +2
Continue to review full report at Codecov.
|
Contributor
|
Hi Nick. Thanks for looking into this! No need for a commit, I guess then. Cheers, Julien. |
Collaborator
|
Anybody recall what happened here ? I see that a fix was prepared but closed rather than merged, but I see nothing in this conversation (or the original issue) that explains the "no need for a commit, I guess" |
weslleyspereira
added a commit
to weslleyspereira/lapack
that referenced
this pull request
May 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible call to laruv routines when N < 1.
See #182.