redis dependencies to get to 4.1.4 #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 81.29% 81.30% +0.01%
==========================================
Files 54 54
Lines 8195 8201 +6
==========================================
+ Hits 6662 6668 +6
Misses 1533 1533
Continue to review full report at Codecov.
|
DvirDukhan
approved these changes
Mar 6, 2022
chayim
commented
Mar 7, 2022
Contributor
Author
chayim
left a comment
chayim
left a comment
There was a problem hiding this comment.
Perfect all around.
Nit (personal style). I'd rather the following, but it's not vital.
from redis.exceptions import (
ResponseError,
ClusterSlotsError
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.