Skip to content

Conversation

DvirDukhan
Copy link

No description provided.

@DvirDukhan DvirDukhan requested review from lantiga and K-Jo September 3, 2020 13:04
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #457 into 1.0 will increase coverage by 0.60%.
The diff coverage is 84.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.0     #457      +/-   ##
==========================================
+ Coverage   72.47%   73.07%   +0.60%     
==========================================
  Files          21       21              
  Lines        4349     4554     +205     
==========================================
+ Hits         3152     3328     +176     
- Misses       1197     1226      +29     
Impacted Files Coverage Δ
src/config.c 18.75% <0.00%> (ø)
src/redisai.h 0.00% <0.00%> (ø)
src/script.c 65.46% <74.71%> (+2.04%) ⬆️
src/model.c 70.79% <75.00%> (+1.19%) ⬆️
src/backends/tensorflow.c 65.45% <76.19%> (-0.06%) ⬇️
src/redisai.c 76.43% <79.31%> (-2.46%) ⬇️
src/backends/onnxruntime.c 68.63% <80.00%> (+0.62%) ⬆️
src/dag.c 88.34% <89.10%> (+0.41%) ⬆️
src/backends/torch.c 82.82% <100.00%> (-1.56%) ⬇️
src/background_workers.c 83.50% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7d365...88177c1. Read the comment docs.

lantiga
lantiga previously approved these changes Sep 9, 2020
@lantiga lantiga mentioned this pull request Sep 16, 2020
@gkorland gkorland changed the title version bump Fix memory leak and version bump Sep 17, 2020
@gkorland gkorland linked an issue Sep 17, 2020 that may be closed by this pull request
@gkorland
Copy link
Contributor

@DvirDukhan don't forget to cherry pick to master

@lantiga
Copy link
Contributor

lantiga commented Sep 17, 2020

@gkorland I'm working on sanitizing master independently

@DvirDukhan DvirDukhan merged commit ecfe7b0 into 1.0 Sep 17, 2020
@DvirDukhan DvirDukhan deleted the v1.0.2 branch September 17, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix 1.0.2 memory leaks
3 participants