Provide support for RAFT-based indexes #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lowener Thanks for much for putting this up! super excited. To run the tests can you sign the CLA? Let me know if you have and it's just not appearing. |
DvirDukhan
reviewed
May 23, 2023
| @@ -0,0 +1,18 @@ | |||
| # ============================================================================= | |||
| # or implied. See the License for the specific language governing permissions and limitations under | ||
| # the License. | ||
|
|
||
| if(NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/RAPIDS.cmake) |
Comment on lines
+28
to
+32
| include(rapids-cmake) | ||
| include(rapids-cpm) | ||
| include(rapids-cuda) | ||
| include(rapids-export) | ||
| include(rapids-find) |
There was a problem hiding this comment.
please add a comment about each specific include purpose
| if (!flat_index_) { | ||
| flat_index_ = std::make_unique<raftIvfFlatIndex>( | ||
| raft::neighbors::ivf_flat::build<DataType, std::int64_t>( | ||
| res_, *build_params_flat_, raft::make_const_mdspan(vector_data_gpu.view()))); |
| int RaftIVFIndex::addVectorBatch(const void *vector_data, labelType *labels, size_t batch_size, | ||
| bool overwrite_allowed) { | ||
| auto vector_data_gpu = | ||
| raft::make_device_matrix<DataType, std::int64_t>(res_, batch_size, this->dim); |
There was a problem hiding this comment.
can you explain ifstd::int64_t is used for id or label?
| return result_list; | ||
| } | ||
| auto vector_data_gpu = | ||
| raft::make_device_matrix<DataType, std::int64_t>(res_, queryParams->batchSize, this->dim); |
There was a problem hiding this comment.
batchSize is misused here. It is used in our batch iterator for hybrid queries
| this->ivf_index_->addVectorBatchGpuBuffer(vectorDataGpuBuffer.data_handle(), | ||
| labels_gpu.data_handle(), | ||
| nVectors); | ||
| updateIvfIndex = false; |
There was a problem hiding this comment.
Once the flat buffer is copied to the IVF it should be flushed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
This PR add support for RAFT-based index. IVF-Flat and IVF-PQ indexes will be added.
The main API change needed is the introduction of Batch vector addition (possibly through a
VecSimIndex_AddVectorBatchfunction)Mark if applicable
Work still in progress