Skip latest #98
Closed
Skip latest #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 91.42% 91.40% -0.02%
==========================================
Files 12 12
Lines 1586 1594 +8
==========================================
+ Hits 1450 1457 +7
- Misses 136 137 +1
Continue to review full report at Codecov.
|
rafie
reviewed
Oct 21, 2020
| # todo: enable once new RS version is tagged | ||
| #self.assertEqual(0.2, res.docs[1].score) | ||
|
|
||
| if check_version_latest(r) is False: |
There was a problem hiding this comment.
if not check_version_latest(r):
rafie
reviewed
Oct 21, 2020
test/test.py
Outdated
|
|
||
| if check_version_latest(r) is False: | ||
| self.assertEqual(0.2, res.docs[1].score) | ||
| print 'something' |
rafie
reviewed
Oct 21, 2020
Comment on lines
+54
to
+56
| if latest is not -1: | ||
| return True | ||
| return False |
|
replaced by #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.