Skip to content

virtualenv cache issue #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 2, 2021
Merged

virtualenv cache issue #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84be46e
upgrading pip due to deps
chayim Nov 2, 2021
bcfe0d2
circle image for py3.6 needs --user pip
chayim Nov 2, 2021
73f97b2
adding cover, fixing tox removals
chayim Nov 2, 2021
60f08b4
cache key change
chayim Nov 2, 2021
33cbc5e
removing cache to test keys
chayim Nov 2, 2021
4002f1b
moving venv to pip upgrade;
chayim Nov 2, 2021
770c94b
virtualenv downgrade due to the pypi cache issue
chayim Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,10 @@ commands:
- abort_for_noci
- checkout

- restore_cache: # Download and cache dependencies
keys:
- v1-dependencies-{{ checksum "pyproject.toml" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chayim why did you cancel the cache?

# fallback to using the latest cache if no exact match is found
- v1-dependencies-

- run:
name: install tox dependencies
command: |
pip install --user --upgrade --quiet pip virtualenv
pip install --user --quiet -r .circleci/circle_requirements.txt

- run:
Expand All @@ -75,13 +70,6 @@ commands:
command:
tox -e cover

- save_cache:
paths:
- ./.tox
- ~/.cache/pip
- ~/.cache/pypoetry
key: v1-dependencies-{{ checksum "pyproject.toml" }}

- store_artifacts:
path: test-reports
destination: test-reports
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ tox = "^3.22.0 || <= 4.0.0"
tox-poetry = "^0.4.0"
bandit = "1.6.0"
vulture = "^2.1"
coverage = "^6.1.1"
virtualenv = "20.9.0"

[build-system]
requires = ["poetry-core>=1.0.0"]
Expand Down
5 changes: 2 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ srcdir = redisearch
show-source = true
exclude =.git,.tox,dist,doc,*/__pycache__/*,*test*.py

# virtualenv bug #2214
[testenv:cover]
whitelist_externals = find
commands_pre =
find . -type f -name "*.pyc" -delete
pip install --upgrade pip
setenv =
REDIS_PORT = 6379
commands =
Expand All @@ -22,8 +23,6 @@ commands =

[testenv:test_without_coverage]
whitelist_externals = find
commands_pre =
find . -type f -name "*.pyc" -delete
setenv =
REDIS_PORT = 6379
commands =
Expand Down