Skip to content

add support to single scheme filed #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2021
Merged

add support to single scheme filed #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd897d8
add support to single scheme filed
AvitalFineRedis Sep 19, 2021
22cad62
some changes
AvitalFineRedis Sep 20, 2021
a3fe202
some changes
AvitalFineRedis Sep 20, 2021
e48c481
Merge branch 'master' into fix_147
AvitalFineRedis Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions redisearch/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,10 @@ def create_index(self, fields, no_term_offsets=False,

args.append('SCHEMA')

args += list(itertools.chain(*(f.redis_args() for f in fields)))
try:
args += list(itertools.chain(*(f.redis_args() for f in fields)))
except TypeError:
args += fields.redis_args()

return self.redis.execute_command(*args)

Expand All @@ -323,7 +326,10 @@ def alter_schema_add(self, fields):

args = [self.ALTER_CMD, self.index_name, 'SCHEMA', 'ADD']

args += list(itertools.chain(*(f.redis_args() for f in fields)))
try:
args += list(itertools.chain(*(f.redis_args() for f in fields)))
except TypeError:
args += fields.redis_args()

return self.redis.execute_command(*args)

Expand Down
4 changes: 2 additions & 2 deletions test/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,10 +826,10 @@ def testAlterSchemaAdd(self):
client.redis.flushdb()

# Creating the index definition and schema
client.create_index((TextField('title'),))
client.create_index(TextField('title'))

# Using alter to add a field
client.alter_schema_add((TextField('body'),))
client.alter_schema_add(TextField('body'))

# Indexing a document
client.add_document('doc1', title='MyTitle', body='Some content only in the body')
Expand Down