-
Notifications
You must be signed in to change notification settings - Fork 60
Add Scorer option to Query #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 90.02% 90.17% +0.14%
==========================================
Files 12 12
Lines 1675 1700 +25
==========================================
+ Hits 1508 1533 +25
Misses 167 167
Continue to review full report at Codecov.
|
@emmanuelkeller please let me know if there's anything you'd like me to add to this PR. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chrisdiana,
Thank you for the PR.
Can you extend the test to include all types of scorers? In addition, add withscore
so we can see the value changes.
Thanks
Thanks @ashtul I've updated the PR with tests for all scorers with scores. Let me know if you want me to add anything else |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you @chrisdiana
deps/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdiana Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashtul when you initially are setting up tests on a new repo and run make -C test/docker test PYTHON_VER=3
generated a ./deps
directory that was dumped into my root path with "readies" inside it. It seemed like someething that wasn't cleaned up that maybe should have so I added to .gitignore
in case the cleanup failed on others environments. I can remove it if you like though.
Add support for using custom scoring functions in a Redisearch query.
Closes #35
TFIDF is the default scoring function but this PR allows users to attach custom scoring functions to a Query object.
https://oss.redislabs.com/redisearch/Scoring/