Skip to content

fix ConcurrentModificationException when other text watchers are installed #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ConcurrentModificationException when other text watchers are installed #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions inputmask/src/main/kotlin/com/redmadrobot/inputmask/MaskedTextChangedListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ open class MaskedTextChangedListener(

private var afterText: String = ""
private var caretPosition: Int = 0
private var textWatcherCallbacksEnabled: Boolean = true

private val field: WeakReference<EditText> = WeakReference(field)

Expand Down Expand Up @@ -209,7 +210,11 @@ open class MaskedTextChangedListener(
fun totalValueLength(): Int = this.primaryMask.totalValueLength()

override fun afterTextChanged(edit: Editable?) {
this.field.get()?.removeTextChangedListener(this)
if (!textWatcherCallbacksEnabled) {
return
}

textWatcherCallbacksEnabled = false
edit?.replace(0, edit.length, this.afterText)

try {
Expand All @@ -228,15 +233,23 @@ open class MaskedTextChangedListener(
)
}

this.field.get()?.addTextChangedListener(this)
textWatcherCallbacksEnabled = true
this.listener?.afterTextChanged(edit)
}

override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) {
if (!textWatcherCallbacksEnabled) {
return
}

this.listener?.beforeTextChanged(s, start, count, after)
}

override fun onTextChanged(text: CharSequence, cursorPosition: Int, before: Int, count: Int) {
if (!textWatcherCallbacksEnabled) {
return
}

val isDeletion: Boolean = before > 0 && count == 0
val useAutocomplete = if (isDeletion) false else this.autocomplete
val useAutoskip = if (isDeletion) this.autoskip else false
Expand Down