Skip to content

Using UUID in class names breaks server-side rendering #580

@birdofpreyru

Description

@birdofpreyru

The commit 78e3c2b breaks the server-side rendering of host code, if the host code uses it, because different UUIDs are generated for the same tooltip at the server-side and client-side, and in result the server-generated markup does not match the one calculated client-side.

At the first glance, I don't follow why was it necessary to introduce UUIDs in class names, it looks to me the static class name __react_component_tooltip worked perfectly, and there was no need to change that as a part of aphrodite-jss deprecation. If you believe UUIDs are really necessary here, they should be exposed as an optional property of tooltip component, so that a user relying on server-side rendering can generate the value himself, then pass and use the same value at the client side.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions