Skip to content

Conversation

@inamiy
Copy link
Member

@inamiy inamiy commented Dec 18, 2014

This pull request will fix unwanted progress-passing from upstream task (parentTask) to downstream.

As-Is

let task3 = task1.then { ... return task2 }
task3.progress { ...
    // called when both task1 & task2's progress() is called
}

NOTE: This is not a good implementation because task1 and task2 may have different Progress type, thus can't mix together.

To-Be

let task3 = task1.then { ... return task2 }
task3.progress { ... 
    // should be called only when task2's progress() is called, just like fulfilled value & rejected errorInfo
}

inamiy added a commit that referenced this pull request Dec 18, 2014
@inamiy inamiy merged commit 91f9ad9 into master Dec 18, 2014
@inamiy inamiy deleted the chained-task-progress branch December 18, 2014 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants