Skip to content

Handling Empty Enums and Duplicate Enum Entries onLoad #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −6
Open

Handling Empty Enums and Duplicate Enum Entries onLoad #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions ReClass.NET/DataExchange/ReClass/ReClassNetFile.Read.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,29 @@ public void Load(Stream input, ILogger logger)
var itemName = itemElement.Attribute(XmlNameAttribute)?.Value ?? string.Empty;
var itemValue = (long?)itemElement.Attribute(XmlValueAttribute) ?? 0L;

values.Add(itemName, itemValue);

if (!values.ContainsKey(itemName))
{
values.Add(itemName, itemValue);
}
else
{

values[itemName] = itemValue;
}
}

var @enum = new EnumDescription
// Check if there are any values before adding the enum to prevent crashing
if (values.Count > 0)
{
Name = name
};
@enum.SetData(useFlagsMode, size, values);
var @enum = new EnumDescription
{
Name = name
};
@enum.SetData(useFlagsMode, size, values);

project.AddEnum(@enum);
project.AddEnum(@enum);
}
}
}

Expand Down