Skip to content

Remove class flip_face #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Override keyword added to all books and code
merged 4 commits into from
May 23, 2020
Merged

Remove class flip_face #602

merged 4 commits into from
May 23, 2020

Conversation

@hollasch
Copy link
Collaborator

With the changes made to handle surface intersection from either side (refer to #270), we no longer have need for the flip_face class. This change removes the class and the associated text in the books.

Resolves #482
Resolves #588

hollasch added 2 commits May 17, 2020 14:40
@hollasch
Remove class flip_face
96b0899 
With the changes made to handle surface intersection from either side
(refer to #270), we no longer have need for the `flip_face` class. This
change removes the class and the associated text in the books.

Resolves #482
Resolves #588
@hollasch
Update changelog with flip_face removal
5d2a417
@hollasch hollasch added this to the v3.2.0 milestone May 17, 2020
@hollasch hollasch requested a review from a team May 17, 2020 21:53
@hollasch hollasch self-assigned this May 17, 2020
dafhi
dafhi approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@dafhi dafhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! if it compiles on your end, i see no issues

@hollasch hollasch merged commit 1e844f5 into dev-minor May 23, 2020
@hollasch hollasch deleted the remove-flip branch May 23, 2020 07:41
Walther added a commit to Walther/clovers that referenced this pull request Jun 27, 2020
@Walther
Add cornell_flips with the flipped faces just in case. Refer to RayTr…
54dba1a 
…acing/raytracing.github.io#602
@Walther Walther mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dafhi dafhi dafhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hollasch hollasch

Labels

None yet

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@hollasch @dafhi