Include hittable.h from material.h #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior version used a forward declaration of `hit_record`, which was insufficient since hittable.h lines referenced members of `hit_record`, and was unnecessary because hittable.h was included before material.h in practice. For this specific code, the inclusion is unnecessary, but is proper form. Resolves #1608
|
@whydoubt — Jeff, I've added you on this review in case you're interested in helping out with PR reviews. Let me know if you are, and I'll add you to the RTW reviewers' group. |
whydoubt
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior version used a forward declaration of
hit_record, which was insufficient since hittable.h lines referenced members ofhit_record, and was unnecessary because hittable.h was included before material.h in practice.For this specific code, the inclusion is unnecessary, but is proper form.
Resolves #1608