Fix build error on musl #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On musl, this fails to build since basename(3) is undefined:
/tmp/src/clr-rocm-6.4.3/rocclr/os/os_posix.cpp:736:27: error: 'basename' was not declared in this scope; did you mean 'rename'?
736 | appName = std::string(basename(buff.get()));
| ^~~~~~~~
| rename
Add the missing import.
|
I wrote these changes for v6.4.3, and have mostly tested there. |
|
Please note active development for clr has moved to ROCm/rocm-systems, please re-open this PR there. |
|
Keep in mind that https://github.com/ROCm/rocm-systems has no tags, so downstream consumers have nothing to track there— we'll continue tracking this repository. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
None
What type of PR is this? (check all applicable)
What were the changes?
Fixed build errors on musl. See commit messages for details.
Why are these changes needed?
Build fails on musl (e.g.: Alpine Linux) without these patches.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks