-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix Alt+Click "open in editor" whe a custom srcDir
is defined.
#7921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks amazing to me.
We are simply a lot the code. Thanks.
I will test the package generated from the PR on Linux and Mac too.
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I think #7923 is a better approach, do you agree? |
I found a way to make the other PR not have to patch launch-editor, so now I think it's a no-brainer to use the other PR instead of this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it?
Description
Problem with the Alt+Click "open in editor" feature when using custom
srcDir
option. see #7785 (comment) for more detail related to the issue.Checklist
pnpm change