Skip to content

Conversation

jails
Copy link

@jails jails commented Sep 7, 2025

What is it?

  • Bug

Description

Problem with the Alt+Click "open in editor" feature when using custom srcDir option. see #7785 (comment) for more detail related to the issue.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@jails jails requested a review from a team as a code owner September 7, 2025 18:42
Copy link

changeset-bot bot commented Sep 7, 2025

⚠️ No Changeset found

Latest commit: ec8fb19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing to me.
We are simply a lot the code. Thanks.
I will test the package generated from the PR on Linux and Mac too.

Copy link

pkg-pr-new bot commented Sep 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7921
npm i https://pkg.pr.new/@builder.io/qwik-city@7921
npm i https://pkg.pr.new/eslint-plugin-qwik@7921
npm i https://pkg.pr.new/create-qwik@7921

commit: 84d39a4

Copy link
Contributor

github-actions bot commented Sep 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 84d39a4

@wmertens
Copy link
Member

wmertens commented Sep 8, 2025

I think #7923 is a better approach, do you agree?

@gioboa
Copy link
Member

gioboa commented Sep 8, 2025

I think #7923 is a better approach, do you agree?

This PR is good because it's solving the specific problem, on the other hand your PR @wmertens is rewriting the logic of this functionality and it's a big improvement too.

@wmertens
Copy link
Member

wmertens commented Sep 8, 2025

I found a way to make the other PR not have to patch launch-editor, so now I think it's a no-brainer to use the other PR instead of this one.

@gioboa gioboa closed this Sep 8, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your amazing help @jails
We decided to solve the issue by changing the implementation and using the same mechanism Vite dev mode already uses.
So that's why we are closing this PR in favor of #7923.
Can you help us and test if it's solving the issue with a custom srcDir please? 🙏
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants