Skip to content

Conversation

knoid
Copy link

@knoid knoid commented Aug 10, 2025

What is it?

  • Bug

Description

Runs the Zod validator inside a withLocale so error messages use the correct language when configured via the setErrorMap method of the zod library.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@knoid knoid requested a review from a team as a code owner August 10, 2025 20:33
Copy link

changeset-bot bot commented Aug 10, 2025

🦋 Changeset detected

Latest commit: 88c6bbc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7804
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7804
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7804
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7804

commit: 88c6bbc

Copy link
Contributor

github-actions bot commented Aug 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 88c6bbc

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I thought that the locale was using async localstorage, which would make this unnecessary, but it's not. I'll make an issue.

LGTM

@wmertens wmertens merged commit d4b426b into QwikDev:build/v2 Aug 11, 2025
19 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knoid for your help 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants