Skip to content

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 6, 2025

What is it?

  • Bug

Description

The service-workers components were not unregistering.

I checked that this works for both on a small repro.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner August 6, 2025 07:26
Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: 565f9d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul self-assigned this Aug 6, 2025
@maiieul maiieul moved this to Waiting For Review in Qwik Development Aug 6, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens
Copy link
Member

wmertens commented Aug 6, 2025

do you think you can also add clearing the caches they were using? 🤔 or does that require actually running a service worker?

Copy link

pkg-pr-new bot commented Aug 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7781
npm i https://pkg.pr.new/@builder.io/qwik-city@7781
npm i https://pkg.pr.new/eslint-plugin-qwik@7781
npm i https://pkg.pr.new/create-qwik@7781

commit: b5200bd

Copy link
Contributor

github-actions bot commented Aug 6, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b5200bd

@maiieul
Copy link
Contributor Author

maiieul commented Aug 6, 2025

Ah right we need to do that too. I'll do this in a follow-up.

@maiieul maiieul merged commit 4199268 into QwikDev:main Aug 6, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 6, 2025
@github-actions github-actions bot mentioned this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants