- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
CircleCI: fix go-lint about scalar multipliers #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: op-es
Are you sure you want to change the base?
Conversation
| } | ||
| 
               | 
          ||
| func fjordL1Cost(l1BlockInfo *derive.L1BlockInfo, rollupCostData types.RollupCostData) *big.Int { | ||
| func fjordL1Cost(config *genesis.DeployConfig, l1BlockInfo *derive.L1BlockInfo, rollupCostData types.RollupCostData) *big.Int { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To minimize the diff, we can just pass 1 as the multipliers for op tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the multipliers are configurable, we may need to read them from the configuration. Otherwise, it is meaningless to run the check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently these multipliers can only be upgraded by upgrade of op-geth.
| 
           The changes for check-fjord looks valid, but I'm not sure whether we're going to use the tool. If not, we can just pass 1 for the multipliers.  | 
    
          
 I guess that depends on our main goal—do we need to keep the tool up to date, simply pass go lint, or minimize the diff?  | 
    
Failed tests:
Verified with: