CGT: all in one #30
Open
CGT: all in one #30
+3,760
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ef03df7. Conflicts: packages/contracts-bedrock/snapshots/.gas-snapshot packages/contracts-bedrock/snapshots/semver-lock.json packages/contracts-bedrock/src/L1/L1CrossDomainMessenger.sol packages/contracts-bedrock/src/L1/L1StandardBridge.sol packages/contracts-bedrock/src/L1/OptimismPortalInterop.sol packages/contracts-bedrock/src/L1/SystemConfigInterop.sol
This reverts commit d64038b.
This reverts commit 6c44b0b.
blockchaindevsh
requested review from
dajuguan,
ping-ke,
qizhou,
qzhodl and
syntrust
blockchaindevsh
force-pushed
the
cgt_all_in_one
branch
from
565b428 to
a30a7f0
Compare
|
For such a large PR, I would recommend adding a suggusted review sequence of the files |
|
Which commit (or release tag) is the target contract from? |
Do you mean the upstream commit we've merged with so far? If so, it's https://github.com/ethereum-optimism/optimism/releases/tag/op-challenger%2Fv1.3.1. |
|
Should the contract version also be downgraded (e.g., SystemConfig from 2.4.0 to 2.3.0)? |
The semantic version doesn't affect functionality and is always supposed to be increased if changed. We don't need to touch it, and the next time we merge with upstream, it'll be updated. |
This was referenced Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables CGT by reverting these 3 PRs:
ethereum-optimism#13921
ethereum-optimism#13686
ethereum-optimism#14094
As of now,
forge testandgastoken_test.go(e2e test for cgt) have passed.But there're some solidity tests skipping CGT(these skippings are all from upstream):
I'm still trying to make them pass without skipping CGT.
UPDATE
All above skipped CGT tests are now re-enabled and passed.