Skip to content

Fixed ml-dsa-65 and ml-dsa-87 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed ml-dsa-65 and ml-dsa-87 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5efcd5f
test 1
Jul 23, 2025
0a393b4
test 2
Jul 23, 2025
2c7f0ef
test 3
Jul 23, 2025
991c549
test 3
Jul 23, 2025
d681444
test 4
Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/sign/ml_dsa_65.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ const L: usize = params::ml_dsa_65::L;
/// * 'sk' - preallocated buffer for private key
/// * 'seed' - optional seed; if None [random_bytes()] is used for randomness generation
pub fn keypair(pk: &mut [u8], sk: &mut [u8], seed: Option<&[u8]>) {
let mut init_seed = [0u8; params::SEEDBYTES];
let mut init_seed = [0u8; params::SEEDBYTES+2];
match seed {
Some(x) => init_seed.copy_from_slice(x),
None => crate::random_bytes(&mut init_seed, params::SEEDBYTES)
Some(x) => init_seed[..params::SEEDBYTES].copy_from_slice(x),
None => crate::random_bytes(&mut init_seed, params::SEEDBYTES),
};

init_seed[params::SEEDBYTES] = K as u8;
init_seed[params::SEEDBYTES+1] = L as u8;

const SEEDBUF_LEN: usize = 2 * params::SEEDBYTES + params::CRHBYTES;
let mut seedbuf = [0u8; SEEDBUF_LEN];
fips202::shake256(&mut seedbuf, SEEDBUF_LEN, &init_seed, params::SEEDBYTES);
fips202::shake256(&mut seedbuf, SEEDBUF_LEN, &init_seed, params::SEEDBYTES+2);

let mut rho = [0u8; params::SEEDBYTES];
rho.copy_from_slice(&seedbuf[..params::SEEDBYTES]);
Expand Down
10 changes: 6 additions & 4 deletions src/sign/ml_dsa_87.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ const L: usize = params::ml_dsa_87::L;
/// * 'sk' - preallocated buffer for private key
/// * 'seed' - optional seed; if None [random_bytes()] is used for randomness generation
pub fn keypair(pk: &mut [u8], sk: &mut [u8], seed: Option<&[u8]>) {
let mut init_seed = [0u8; params::SEEDBYTES];
let mut init_seed = [0u8; params::SEEDBYTES+2];
match seed {
Some(x) => init_seed.copy_from_slice(x),
None => crate::random_bytes(&mut init_seed, params::SEEDBYTES)
Some(x) => init_seed[..params::SEEDBYTES].copy_from_slice(x),
None => crate::random_bytes(&mut init_seed, params::SEEDBYTES),
};
init_seed[params::SEEDBYTES] = K as u8;
init_seed[params::SEEDBYTES+1] = L as u8;

const SEEDBUF_LEN: usize = 2 * params::SEEDBYTES + params::CRHBYTES;
let mut seedbuf = [0u8; SEEDBUF_LEN];
fips202::shake256(&mut seedbuf, SEEDBUF_LEN, &init_seed, params::SEEDBYTES);
fips202::shake256(&mut seedbuf, SEEDBUF_LEN, &init_seed, params::SEEDBYTES+2);

let mut rho = [0u8; params::SEEDBYTES];
rho.copy_from_slice(&seedbuf[..params::SEEDBYTES]);
Expand Down