-
Notifications
You must be signed in to change notification settings - Fork 13
refactor: Discontinue most parts of mypy plugin #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 40 -1
Lines 2401 2389 -12
=========================================
- Hits 2401 2389 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of complexity gone 😅
I'm a little confused on the scope of this change. Will |
Sorry for the confusion @runkelcorey! All the features that you'd expect from First of all, this change only has an effect if you use dataframely's
Both of these things did more harm than good. The former was sometimes evaluated incorrectly when mypy used caching. The latter caused the user to not be able to use the failure info dictionary as So tl;dr: if you do not rely on these two things, this PR won't have an effect on your usage. |
Motivation
Closes #54.
Changes
Discontinue mypy plugin features that are hard to maintain and provide limited value.