Adds Support to Named Arguments #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for named arguments (pythonnet#849) * Remove kwarg check since it breaks the python-derived CLR class use-case * Add named parameter test cases * Update changelog and authors * Add default params tests
Pick-cherry from pythonnet master and resolve conflicts.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 69.42% 69.42%
=======================================
Files 1 1
Lines 278 278
=======================================
Hits 193 193
Misses 85 85
Continue to review full report at Codecov.
|
Remoes `break` at `AssemblyManager.Initialize` added for debugging/testing.
Member
Martin-Molinero
left a comment
Martin-Molinero
left a comment
There was a problem hiding this comment.
Looks good 👍 leaving a minor performance suggestion, believe we need a new version bump. Would be nice to run some of Lean python performance benchmarks
| IntPtr op; | ||
| if (hasNamedParam) | ||
| { | ||
| op = kwargDict[parameter.Name]; |
Member
There was a problem hiding this comment.
Think could use kwargDict.TryGetValue at the top and avoid accessing the dictionary twice
Member
|
Closing in favor of #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick-cherry (pythonnet#849)) from pythonnet master and resolve conflicts.