Update with Lean enhancements #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convertes System.Decimal to decimal.decimal and vice-versa
Converts System.DateTime and System.TimeSpan to datetime.datetime and datetime.timedelta and vice-versa
jaredbroad
reviewed
Jul 13, 2018
| typeType = typeof(Type); | ||
|
|
||
| IntPtr decimalMod = Runtime.PyImport_ImportModule("decimal"); | ||
| if (decimalMod == null) throw new PythonException(); |
Member
There was a problem hiding this comment.
Can this throw a more meaningful error? Can you include any information in the exception?
Member
Author
There was a problem hiding this comment.
No. PythonException doesn't accept any arguments.
When it is thrown, it looks for the exception hanging on python environment and display it.
It is a shame, because we could attach a custom message...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.