Adding ScfUnroll Pass
#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Roger-luo
approved these changes
Sep 17, 2025
weinbe58
added a commit
that referenced
this pull request
Sep 17, 2025
This PR packages the current `scf.unroll` rewrite rules into a pass to be used to try and unroll the scf. The usage: ```python from kirin. passes.aggressive import UnrollScf UnrollScf(dialects).fixpoint(method) ``` For a single application, this pass unrolls the top-level of scf nodes in the method body. Therefore, to unroll nested SCF you must apply this in a fixpoint way. The modification if removing `terminate` in the UnrollFor rewrite rule fixes issue #475 because now this Pass fixpoint should be over the depth of the nesting, not the number of iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR packages the current
scf.unrollrewrite rules into a pass to be used to try and unroll the scf.The usage:
For a single application, this pass unrolls the top-level of scf nodes in the method body. Therefore, to unroll nested SCF you must apply this in a fixpoint way.
The modification if removing
terminatein the UnrollFor rewrite rule fixes issue #475 because now this Pass fixpoint should be over the depth of the nesting, not the number of iterations.