Skip to content

Complete Core Functionality #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jan 4, 2023
Merged

Complete Core Functionality #1

merged 28 commits into from
Jan 4, 2023

Conversation

johnzl-777
Copy link
Collaborator

@johnzl-777 johnzl-777 commented Jan 4, 2023 •
edited
Loading

  • Implemented csr_mv_merge!, mul!, and fixed pre-existing atomic addition operations
  • Added unit tests for all functions against dimensions/vectors of different sizes with complex and real matrices/vectors/coefficients

weinbe58 and others added 28 commits December 20, 2022 16:45
@weinbe58
removing old files and setting todos
51c8ece
@weinbe58
override SparseArrays Mul!
931e670
@weinbe58
updating TODOs
e8753b0
@weinbe58
adding tests
cd96e34
@weinbe58
adding += operator
8e12ae2
@johnzl-777
Fixed broken .toml
ededb98
@johnzl-777
Added testing ability to .toml, merge_csr_mv! works with CSC format a…
4e979f5 
…nd Number multiplier
@johnzl-777
Added @inbounds, use nnz to denote number of nonzeros vs length(nz)
eb4604f
@johnzl-777
Attempted fix for atomic ops, renamed args for merge_csr_mv, add tests
b62adb7
@johnzl-777
Fixed broken default matrix-matrix, matrix-vector mul, added simple t…
f7f46b2 
…ests
@johnzl-777
Added test for matrix x matrix operation using merge_csr_mv!
45478d1
@johnzl-777
Fixed issue with zeros, partial fix for AB\alpha operation inside mul…
381437f 
…! not mutating
@weinbe58
fixing issue with mul!
84393bc
@johnzl-777
Try to use @view to fix issue with matrix not being mutated
1a89711
@johnzl-777
Merge remote-tracking branch 'refs/remotes/origin/csrmv_merge' into c…
8e9a71d 
…srmv_merge
@johnzl-777
Add tests for transpose on square and rectangular matrices
b6c26cc
@johnzl-777
Changed unit tests to match new argument ordering
182aaa5
@weinbe58
adding StridedVector type
35af5fe
@johnzl-777
fixed segfault, revised some tests to adjoint/transpose matrix v. pla…
8cd636b 
…in matrix
@johnzl-777
Merge remote-tracking branch 'refs/remotes/origin/csrmv_merge' into c…
b911851 
…srmv_merge
@weinbe58
fixing imports
34eda6b
@weinbe58 @johnzl-777
rm inbounds no longer overloading SparseArray.mul!
366d2e8 
Co-authored-by: John Long <[email protected]>
@johnzl-777
Fixed issue with incorrect output and updated tests to always use tra…
778d524 
…nsposed/adjointed matrices
@johnzl-777
Add @inbounds
938ecd7
@johnzl-777
Removed unnecessary comments, added SparseArrays definition override
c9b8ccc
@johnzl-777
Reordered imports to alphabetical order
5217a3c
@johnzl-777
added complex-valued unit tests for merge_csr_mv, removed incompatibl…
b033e3d 
…e tests
@johnzl-777
Added test for complex and real-valued matrices/vectors/coefficients …
87852a6 
…in mul
@johnzl-777
Copy link
Collaborator Author

Merging into main to maintain proper branch scope and begin work on CI

@johnzl-777 johnzl-777 merged commit a39cad0 into main Jan 4, 2023
@johnzl-777 johnzl-777 deleted the csrmv_merge branch January 4, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnzl-777 @weinbe58