type piracy

[Roger-luo]

We should get rid of this type of piracy by switching to a different name, otherwise, this will invalidate the original mul! method, we should support this by an if-else inside Bloqade and other packages calling the function.

ParallelMergeCSR.jl/src/ParallelMergeCSR.jl

Line 194 in eabcc55

function mul!(C::StridedVecOrMat, xA::$T{<:Any,<:AbstractSparseMatrixCSC}, B::DenseInputVecOrMat, α::Number, β::Number)

It's a bit annoying, but things have to be done in this way until we have method overlay support from Julia compiler.

nvm, I just realize it's not overloaded.

[Roger-luo]

I think then we shouldn't export it, or should use a different name because this will cause the following if using it naively

julia> mul!(y, A, b, 1.0, 0.0)
WARNING: both LinearAlgebra and ParallelMergeCSR export "mul!"; uses of it in module Main must be qualified
ERROR: UndefVarError: mul! not defined
Stacktrace:
 [1] top-level scope
   @ REPL[7]:1

[weinbe58]

Good point, we don't need to export the function

[johnzl-777]

Good point, we don't need to export the function

#29 goes down this route 🤠