NUMA-awareness fixes (replaces #652) #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case libnuma is not found, NUMA_FOUND is (can be?) not defined instead of being set to 0.
and speeding up Windows compilation
Closed
|
@lucjaulmes I think it's ready to merge! It was my original intention to squash and give you authorship of my changes too, though they ended up more substantial than expected (and include lots of doc which is only my interpretation of the logic - so it might be wrong!). Would you be okay to coauthor the squash (which will link to this PR to disambiguate commits)? |
|
Docs & changes look good to me. Commit authorship is as you prefer, it’s documented in files anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #652 (preserving @lucjaulmes's commits) to add additional polish and defensive design. The previous PR was astonishingly impossible for me to make changes to, locally and through codespaces - rebase mischief?!