Skip to content

Conversation

@diogomaia00
Copy link
Contributor

My bad for the errors made
I’ve decided to make another PR, hope this time will work:

  • forked from devel
  • cleaned the comments I forgot to clean
  • inserted the new function header in the operations.h

Thanks for the patience and help

@TysonRayJones
Copy link
Member

LGTM! Ignore the failing CI - that's due to something unrelated breaking in the installation of the ROCm compiler.

As you'll have noticed, this UH challenge turned out way easier than expected after fleshing out the issue, boiling down to merely changing a type and copy/pasting a body. That's totally fine - you've earned the challenge! - but does mean I'm going to be pedantic :^) So could you please:

  • undo the deletion of terminal newlines in the modified files?
  • remove the trailing whitespace introduced after the open braces?
  • add /// @notyetdoced above applyNonUnitaryPauliGadget in operations.h?

I actually tried to do all three myself but don't have permission to write directly to your fork 🙏

@TysonRayJones
Copy link
Member

Perfect! You've completed the challenge to my satisfaction - I'll assign it to you now 🎉 I won't merge this PR yet since I'll quickly follow it with unit tests and want to keep the reminder active. So please keep this PR open!

@TysonRayJones
Copy link
Member

Oops, please leave a quick comment on Issue #594 so that I can award it to you 🙌

@TysonRayJones
Copy link
Member

@diogomaia00 Are you happy to be included in QuEST's authorlist, and do you have a preferred name over your github handle?

@diogomaia00
Copy link
Contributor Author

@diogomaia00 Are you happy to be included in QuEST's authorlist, and do you have a preferred name over your github handle?

Yes of course, that’s very generous of you. Thank you. I’d prefer you to use Diogo Pratas Maia if it’s not to much :)

and added Mai to memory.cpp authorlist as previously forgotten
@TysonRayJones TysonRayJones merged commit 5fa4f60 into QuEST-Kit:devel Jun 4, 2025
@TysonRayJones TysonRayJones mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants