Implement cross-platform RAM query and refactor memory.cpp #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roll249
commented
May 31, 2025
Roll249
commented
- Implements mem_tryGetLocalRamCapacityInBytes() using sysinfo on Linux, sysctl on macOS, and GlobalMemoryStatusEx on Windows.
- Moves platform-specific includes to the top of memory.cpp for clarity.
- Cleans up indentation and newlines.
- Removes build/ from the repository and adds it to .gitignore.
- Supersedes previous PR to main; this one targets devel as requested.
…cityInBytes() for Linux, macOS, and Windows. Falls back to exception if not available.
…e platform includes to top, improve clarity. Remove build/ from repo and add to .gitignore.
Contributor
Author
|
@TysonRayJones ok let check it bro |
since the windows.h header otherwise defines a `min` and `max` macro which interferes with the existing functions used in this file
it's faster to just do it myself ¯\_(ツ)_/¯
Contributor
Author
|
@TysonRayJones =)) oke |
Member
|
Hi there, edit: please comment on that issue to appear among the 'assignees' list |
Contributor
Author
|
@TysonRayJones thank you |
Member
|
Note to self:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.