feat!: 157 daily problem design #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamic load daily
loaded from daily json
daily plans
load from daily
folder after plan problem
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a design for dynamically loading daily coding problems across multiple languages and build systems (Python, C++, Java, and TypeScript) using a JSON configuration file named daily-{PROBLEM_FOLDER}.json. Key changes include updated Bazel rules and repository setups, modifications to test harnesses in various languages, and documentation updates to guide users on the new configuration.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| solutions.bzl | Updated function names and added a dynamic enable flag. |
| qubhjava/test/TestMain.java | Replaced static problem instantiation with reflection and added static block initialization for problem IDs. |
| qubhjava/test/ProblemsTest.java | Updated test static block to load problems dynamically. |
| python tests and writers | Migrated file path handling to pathlib and updated JSON loading for daily problems. |
| pom.xml and MODULE.bazel | Updated build configuration to support dynamic problem sources and bumped version. |
| daily-problems.json | Added new configuration file for daily and planned problems. |
Comments suppressed due to low confidence (1)
pom.xml:196
- [nitpick] The change in the sourceDirectory from '.' to 'qubhjava' may affect the build structure. Please update the project documentation to clearly describe the new layout and rationale.
<sourceDirectory>qubhjava</sourceDirectory>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3, C++, Java and Typescript now dynamically load daily problems according to json file
daily-{PROBLEM_FOLDER}.jsonfile