[DOC] Fix gradient update for "Wasserstein 2 Minibatch GAN" example #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
The code sample from the documentation page "Wasserstein 2 Minibatch GAN" has been updated to zero out the gradient after each batch.
Motivation and context / Related issue
The issue was described in #464. I also reviewed other sections in the documentation where the PyTorch optimizer is used, and found that all other code samples properly call
zero_grad()
.I experimented with various optimizers and settings, such as
SGD
, but the difference in wall time was negligible. I'm not sure if it's worth updating for performance reasons alone. @rflamary let me know what do you think.PR checklist