futurize: bug in converting "if type(fn) in types.StringTypes:"

[edschofield]

Currently this conversion is done::

-        if type(fn) in types.StringTypes:
+        if type(fn) in str:

which is clearly wrong ...

[hawko2600]

Hi Ed,

Is this why metaclass construction is broken?

DBS = type(str('DatabaseTable'), (tables.IsDescription,), {k:v for k,v in self.mydata.dtype.descr})

TypeError: type() argument 1 must be string, not newstr

[rgant]

A work around for this issue I found is to call types.StringType directly:

import types
Bar = type(types.StringType('Bar'), (Foo,), {})

[Mark-E-Hamilton]

Hi,
What is the status of this? I just ran into it today. Seems like the correct conversion would be to this:

if isinstance(some_string, types.StringTypes):

However, if I make that change and then run futurize again, it changes it to this:

-  if isinstance(some_string, types.StringTypes):
+  if isinstance(some_string, str):