Skip to content

Add tltk #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 30, 2021
Merged

Add tltk #599

merged 22 commits into from
Jul 30, 2021

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Jul 29, 2021 •
edited
Loading

What does this changes

Add tltk engine to pythainlp

What was wrong

Add tltk engine

Function

  • Sentence tokenizer
  • word segment
  • syllable_tokenize
  • romanize
  • tltk_g2p - Thai Grapheme-to-Phoneme
  • tltk_ipa - tltk, output is International Phonetic Alphabet (IPA)
  • pos_tag
  • spell
  • ner

TLTK Homepage: https://pypi.org/project/tltk/

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jul 29, 2021 •
edited
Loading

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-29 13:33:42 UTC

@wannaphong wannaphong changed the title [WIP] Add tltk Add tltk Jul 29, 2021
@coveralls
Copy link

coveralls commented Jul 29, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 97.762% when pulling f7d99eb on add-tltk into 2e9ac04 on dev.

@wannaphong wannaphong requested a review from bact July 29, 2021 13:06
@wannaphong wannaphong merged commit e5ec352 into dev Jul 30, 2021
@wannaphong wannaphong mentioned this pull request Jul 30, 2021
Closed
@wannaphong wannaphong deleted the add-tltk branch July 31, 2021 08:01
@wannaphong wannaphong added this to the 2.3 milestone Dec 27, 2021
@wannaphong wannaphong modified the milestones: 2.3, 3.0 Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact Awaiting requested review from bact

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@wannaphong @pep8speaks @coveralls