Skip to content

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 12, 2021

What does this changes

Add Thai Text Augmentation #578

How this fixes it

Description of how the changes fix the issue.

Fixes #578

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jun 12, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 75:9: E722 do not use bare 'except'

Line 13:80: E501 line too long (96 > 79 characters)

Comment last updated at 2021-07-16 18:48:28 UTC

@wannaphong wannaphong changed the title Add pythainlp.textaugment [WIP] Add pythainlp.textaugment Jun 12, 2021
@wannaphong wannaphong changed the title [WIP] Add pythainlp.textaugment Add pythainlp.textaugment Jun 12, 2021
@wannaphong wannaphong requested a review from bact June 12, 2021 10:04
@bact
Copy link
Member

bact commented Jun 14, 2021

To keep the name a bit consistent with others like pythainlp.tokenize, .translate, .transliterate, what about pythainlp.augment ?

@wannaphong
Copy link
Member Author

To keep the name a bit consistent with others like pythainlp.tokenize, .translate, .transliterate, what about pythainlp.augment ?

I agree. I will change it.

@wannaphong wannaphong changed the title Add pythainlp.textaugment Add pythainlp.augment Jun 14, 2021
@wannaphong
Copy link
Member Author

@bact I think it's ready.

@coveralls
Copy link

coveralls commented Jul 16, 2021

Coverage Status

Coverage decreased (-0.5%) to 95.541% when pulling c638e95 on add-textaugment into ad20a1e on dev.

@wannaphong
Copy link
Member Author

Coverage Status

Coverage decreased (-0.5%) to 95.541% when pulling c638e95 on add-textaugment into ad20a1e on dev.

Welcome back!

@wannaphong wannaphong merged commit f2ae223 into dev Jul 16, 2021
@wannaphong wannaphong added this to the 2.4 milestone Jul 22, 2021
@wannaphong wannaphong deleted the add-textaugment branch July 29, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Thai Text Augmentation

4 participants