-
Notifications
You must be signed in to change notification settings - Fork 285
Add pythainlp.generate #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-17 16:58:09 UTC |
|
To keep the name a bit consistent with others like pythainlp.tokenize, .translate, .transliterate, what about pythainlp.generate ? |
I agree. I will change it. |
|
@bact OK. I fixed code. |
What does this changes
Add
pythainlp.generateto PyThaiNLP. It's thai text generator from ttg.Fixes #577
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.