Skip to content

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Jun 11, 2021

What does this changes

Add pythainlp.generate to PyThaiNLP. It's thai text generator from ttg.

Fixes #577

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@pep8speaks
Copy link

pep8speaks commented Jun 11, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 138:9: E722 do not use bare 'except'
Line 231:9: E722 do not use bare 'except'

Line 32:1: E722 do not use bare 'except'

Line 217:9: E722 do not use bare 'except'

Comment last updated at 2021-07-17 16:58:09 UTC

@wannaphong wannaphong changed the title Add pythainlp.generator [WIP] Add pythainlp.generator Jun 11, 2021
@wannaphong wannaphong changed the title [WIP] Add pythainlp.generator Add pythainlp.generator Jun 12, 2021
@wannaphong wannaphong requested a review from bact June 12, 2021 07:09
@bact
Copy link
Member

bact commented Jun 14, 2021

To keep the name a bit consistent with others like pythainlp.tokenize, .translate, .transliterate, what about pythainlp.generate ?

@wannaphong
Copy link
Member Author

consistent

I agree. I will change it.

@wannaphong wannaphong changed the title Add pythainlp.generator Add pythainlp.generate Jun 14, 2021
@bact bact added the enhancement enhance functionalities label Jun 21, 2021
@bact bact added this to the Future milestone Jun 21, 2021
@wannaphong
Copy link
Member Author

@bact OK. I fixed code.

@coveralls
Copy link

coveralls commented Jul 16, 2021

Coverage Status

Coverage increased (+0.06%) to 95.778% when pulling 5da36f0 on add-text-generator into 48f67d2 on dev.

@wannaphong wannaphong merged commit 259daf1 into dev Jul 21, 2021
@wannaphong wannaphong modified the milestones: Future, 2.4 Jul 22, 2021
@wannaphong wannaphong deleted the add-text-generator branch July 29, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement enhance functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Thai Text Generator

4 participants