Skip to content

Conversation

@bact
Copy link
Member

@bact bact commented May 27, 2021

What does this changes

Update the function call to get word vector in pythainlp/word_vector/core.py

What was wrong

Deprecated word_vec() is called.

How this fixes it

Use get_vector() instead.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label May 27, 2021
@bact bact self-assigned this May 27, 2021
@bact bact added this to the 2.4 milestone May 27, 2021
@coveralls
Copy link

coveralls commented May 27, 2021

Coverage Status

Coverage decreased (-0.03%) to 95.946% when pulling 521bc25 on fix-deprecate-word-vec into ab888cc on dev.

@bact bact merged commit ea53ea4 into dev Jun 1, 2021
@bact bact deleted the fix-deprecate-word-vec branch June 1, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants