-
Couldn't load subscription status.
- Fork 285
Tokenize repeating dots and commas from numbers (fix #461) #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-20 09:14:55 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Can we add test cases for this?
May be something like:
- "19..." -> ['19', '...']
- "19." -> ['19', '.']
- "19.84" -> ['19.84']
- "127.0.0.1" -> ['127.0.0.1']
- "USD1,984.42" -> ['USD', '1,984.42']
OK |
|
I think the code and the test cases themselves are good (thanks), but the problem is around coverall for macOS hmm.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code and the test cases are good. Thank you.
What does this changes
I change a rule of
_RE_NONTHAIinnewmmandmulti_cut.How this fixes it
Add rule of float number and number.
Fixes #461
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.