Skip to content

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented May 17, 2021

What does this changes

I change a rule of _RE_NONTHAI in newmm and multi_cut.

ภาพ

How this fixes it

Add rule of float number and number.

Fixes #461

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@wannaphong wannaphong requested a review from bact May 17, 2021 08:54
@coveralls
Copy link

coveralls commented May 17, 2021

Coverage Status

Coverage increased (+0.05%) to 95.794% when pulling 86eae1c on fix-461 into c7a37b2 on dev.

@wannaphong
Copy link
Member Author

@bact bact changed the title Fixed #461 Tokenize repeating dots and commas from numbers (fix #461) May 17, 2021
@bact bact added the enhancement enhance functionalities label May 17, 2021
@bact bact added this to the 2.4 milestone May 17, 2021
@pep8speaks
Copy link

pep8speaks commented May 17, 2021

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-20 09:14:55 UTC

Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Can we add test cases for this?

May be something like:

  • "19..." -> ['19', '...']
  • "19." -> ['19', '.']
  • "19.84" -> ['19.84']
  • "127.0.0.1" -> ['127.0.0.1']
  • "USD1,984.42" -> ['USD', '1,984.42']

@wannaphong
Copy link
Member Author

Nice work. Can we add test cases for this?

May be something like:

* "19..." -> ['19', '...']

* "19." -> ['19', '.']

* "19.84" -> ['19.84']

* "127.0.0.1" -> ['127.0.0.1']

* "USD1,984.42" -> ['USD', '1,984.42']

OK

@wannaphong wannaphong requested a review from bact May 20, 2021 09:42
@bact
Copy link
Member

bact commented May 22, 2021

I think the code and the test cases themselves are good (thanks), but the problem is around coverall for macOS hmm..

Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and the test cases are good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement enhance functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with syllable tokenization

4 participants