Skip to content

Add create_wordlist #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 27, 2020
Merged

Add create_wordlist #502

merged 6 commits into from
Dec 27, 2020

Conversation

@wannaphong
Copy link
Member

@wannaphong wannaphong commented Dec 14, 2020 •
edited
Loading

Tool for create word list to optimized word tokenize from dataset
code is from Korakot Chaovavanich.

:See Also:
* Facebook post https://www.facebook.com/groups/colab.thailand/permalink/1667821073393244
* Google Colab https://colab.research.google.com/drive/19kY2jCHONuxmTJM0U8PIE_I5OK1rO-x_

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Passed code styles and structures
  • Passed code linting checks and unit test

@wannaphong wannaphong requested review from bact and korakot December 14, 2020 16:17
@pep8speaks
Copy link

pep8speaks commented Dec 14, 2020 •
edited
Loading

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-17 09:00:34 UTC

@wannaphong wannaphong changed the title Add create_wordlist [WIP] Add create_wordlist Dec 14, 2020
@coveralls
Copy link

coveralls commented Dec 14, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 95.531% when pulling d5bd30a on add-create_wordlist into 82e71e4 on dev.

bact
bact requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.
Please add docstrings and test.

@bact bact added the enhancement enhance functionalities label Dec 17, 2020
@bact bact added this to the 2.3 milestone Dec 17, 2020
@wannaphong wannaphong changed the title [WIP] Add create_wordlist Add create_wordlist Dec 22, 2020
@wannaphong
Copy link
Member Author

I think now it is ready.

@bact bact merged commit e2243df into dev Dec 27, 2020
@bact bact deleted the add-create_wordlist branch December 27, 2020 12:15
@bact bact mentioned this pull request Dec 27, 2020
Closed
@wannaphong wannaphong mentioned this pull request Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bact bact bact requested changes

@korakot korakot Awaiting requested review from korakot

Assignees

No one assigned

Labels

enhancement enhance functionalities

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

4 participants

@wannaphong @pep8speaks @coveralls @bact