Skip to content

Conversation

wannaphong
Copy link
Member

Add attacut-sc and attacut-c to AttaCut docs on PyThaiNLP Docs.

fix PyThaiNLP/attacut#22

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2020

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-07 05:18:14 UTC

@coveralls
Copy link

coveralls commented Oct 9, 2020

Coverage Status

Coverage decreased (-0.07%) to 95.417% when pulling c083169 on update-attacut into 329812e on dev.

@bact bact changed the title Update attacut Add model option to attacut.tokenize() Oct 10, 2020
@bact bact self-requested a review October 10, 2020 06:47
@wannaphong
Copy link
Member Author

@bact if you accepted this pull requests, could you add adding the "hacktoberfest-accepted" label to this pull requests,.

@bact bact added hacktoberfest-accepted hacktoberfest accepted pull requests. enhancement enhance functionalities documentation improve documentation and test cases labels Oct 10, 2020
@bact bact added this to the 2.3 milestone Oct 10, 2020
Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ดูแล้วโค้ดอาจจะไม่ thread safe ครับ

@bact bact merged commit 82e71e4 into dev Dec 14, 2020
@bact bact deleted the update-attacut branch December 14, 2020 08:26
@bact bact mentioned this pull request Dec 14, 2020
@wannaphong wannaphong mentioned this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation improve documentation and test cases enhancement enhance functionalities hacktoberfest-accepted hacktoberfest accepted pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

เพิ่ม option attacut-sc และ attacut-c ใน engine เมื่อเรียก from pythainlp.tokenize import word_tokenize

4 participants